Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeping BSQ trading fee discount at 50% of BTC #202

Closed
MwithM opened this issue Apr 3, 2020 · 12 comments
Closed

Keeping BSQ trading fee discount at 50% of BTC #202

MwithM opened this issue Apr 3, 2020 · 12 comments
Assignees
Milestone

Comments

@MwithM
Copy link

MwithM commented Apr 3, 2020

This is a Bisq Network proposal. Please familiarize yourself with the submission and review process.

Motivation

After approval of proposals #173 and #181 regarding trading fees, a process to keep BSQ discount up to date in a regular, systematic way is still needed.

Proposal

3 days before end of proposal phase, Compensation maintainer will use this spreadsheet to calculate current and, if needed, new BSQ trading fees. New BSQ trading fees will be submitted to DAO vote only when the discount is 5% over or under the 50% mark. To reduce trader impact in case of sudden BSQ price drop, (edited) max BSQ % variation for current and proposed fees should be a 15% increase (i.e. if current discount BSQ trading fees are 10 BSQ, max new BSQ trading fees should be 11.5 BSQ, even when that supposes leaving the discount over 50%).

The parameters used to calculate the discount will be USD/BSQ 30 day volume weighted average and current USD/BTC price as displayed in a Bisq node.

The process is detailed in the wiki.


Edit: Max BSQ % variation for current and proposed trading fees increase is 15%.

@sqrrm
Copy link
Member

sqrrm commented Apr 3, 2020

I think this is good in principle, but would suggest that the fees could change by up to 20 percentage points per cycle, and it would only be done when the discount is 10 percentage points off the 50% mark.

Having a very precise measure makes little sense since both BTC and BSQ prices are quite volatile.

@MwithM
Copy link
Author

MwithM commented Apr 3, 2020

@sqrrm Thanks for taking a look at this proposal.

Maybe I did not explain correctly how the numbers are calculated, or they're calculated in a strange way in the spreadsheet. I created a third sheet with the calculations of a sudden drop in BSQ price scenario to show how it would be.

imagen

fees could change by up to 20 percentage points per cycle

The max discount difference of 5% variation means that if now the discount is 60%, for the next cycle it should be 55% for the nex. As it's calculated on the spreadsheet, implies that a maximum of a 13% BSQ increase is allowed.
Going from 46 BSQ per BTC traded to 52 BSQ per BTC from one cycle to next one looks high ennough to me.
As I understand, you're proposing to be able to go from 46 BSQ to 55 BSQ, which is not very far from the current proposal. One objective of this proposal is to make trading fee changes steady. The reason why #173 was rejected was because that change looked too abrupt.

it would only be done when the discount is 10 percentage points off the 50% mark

Fees would have to be checked periodically anyway, so I think that a 5% distance from the mark should be used. For the DAO it's a simple vote for two parameters, as rules are already known and easy to check consulting the spreadsheet. For contributors and traders, keeping the discount the closer possible to 50% makes it easier to predict revenue and expenses.

@MwithM
Copy link
Author

MwithM commented Apr 5, 2020

@sqrrm I changed the spreadsheet, now the BSQ variation is easier to understand.
Anyway, my proposal is kept to cap max BSQ % variation for current and proposed fees at 15% increase, and make a change parameter proposal when BSQ discount is 5% over or under 50%.

@sqrrm
Copy link
Member

sqrrm commented Apr 5, 2020

That's reasonable, gave my thumbs up.

@MwithM
Copy link
Author

MwithM commented Apr 17, 2020

Update for cycle 12

There's no need to update fees for Cycle 12. Current BSQ discount is 50.1%, into the 44-55% range.

7050 USD/BTC and 0.61 USD/BSQ has been used to calculate new fees. USD/BTC is bitcoinaverage price at this time, and USD/BSQ is weighted volume 30 day moving average as displayed in Bisq node v1.3.2

imagen

You can view the spreadsheet here

I consider this proposal approved and voting not necessary. Changes are small and I have not seen opposition to it. The 15% cap on BSQ % raise might be the most controversial or subject to change aspect of this proposal, I consider this part of the proposal open for review in next cycles.

@cbeams @mpolavieja Do you think that for next cycles, a new proposal should be open, or should this one be kept open? I think that Proposals is the best way to proceed with this. I'll do what you think it's best, and modify the wiki accordingly.

@MwithM
Copy link
Author

MwithM commented May 18, 2020

Cycle 13

Prices used: 9620 USD/BTC and 0,63 USD/BSQ (30 day WMA)
Current fees BSQ discount: 62,6%
New fees BSQ discount: 56,9%

There's a need to update BSQ trading fees, as discount is over 55%. The 15% cap for BSQ trading fee increase will be used.

image

New BSQ trading fees

A change parameter request for BSQ trading fees will be submitted to DAO voting:
New BSQ maker fee: 6.6 BSQ
New BSQ taker fee: 46.3 BSQ


Spreadsheet (cryptpad spreadsheet was broken due to a bug): https://docs.google.com/spreadsheets/d/1-hISy7F0NSqPnRxDOoi1k7df1qLJHfQTxhrVLt6NbX4/edit#gid=0
Process described at: https://bisq.wiki/Update_BSQ_trading_fees

@sqrrm
Copy link
Member

sqrrm commented May 18, 2020

image
Should that be 46.3 as mentioned in the table?

@MwithM
Copy link
Author

MwithM commented May 18, 2020

Yes, it's edited now. I'm waiting for lower mining fees to send the proposals to DAO.

@MwithM
Copy link
Author

MwithM commented May 19, 2020

TXID for change parameter proposals:
1cfdff7ef0bdf72275ffe6b8191817d229384493c9035d42a950f37c8c2b2abe
759c456d684481bec1a889a8ee03398750a0eded696d255661c665217f23181d

Edit: I did a mistake sending a wrong change parameter to vote and apparently remove proposal failed. Proposal with TXID da03886ca7c0e9942d969be7d032d0cf12442cdf68f9721a274a8b1f64112336 (maker fee 7.2 BSQ) should be rejected.

@MwithM
Copy link
Author

MwithM commented Jun 1, 2020

After change parameter proposals were approved, I have updated the wiki page with the new BSQ trading fees. https://bisq.wiki/Trading_fees
I'm closing this issue while we figure out the best way to keep record of the process, I don't like to create a new proposal every cycle nor leaving this forever and generate a mega thread.

@MwithM MwithM closed this as completed Jun 1, 2020
@MwithM
Copy link
Author

MwithM commented Jun 21, 2020

I'm reopening this proposal. The plan is to keep using this one until there's a need to update BSQ trading fees again. For more info, read the wiki or proceed to #compensation keybase Bisq channel.

Cycle 14

Parameters

  • USD/BTC price: 9365 USD
  • USD/BSQ price: 0.72 USD
  • Current BSQ discount: 49.5%

imagen

There's no need to update BSQ trading fees for Cycle 14.

@MwithM
Copy link
Author

MwithM commented Jul 22, 2020

Closed: new BSQ trading fees have been proposed for Cycle 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants