Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Cycle 17 #668

Closed
cbeams opened this issue Sep 22, 2020 · 14 comments
Closed

For Cycle 17 #668

cbeams opened this issue Sep 22, 2020 · 14 comments
Assignees
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:admin https://bisq.wiki/Admin_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Milestone

Comments

@cbeams
Copy link
Member

cbeams commented Sep 22, 2020

Summary

  • BSQ requested: 74.63
  • USD requested: 50
  • BSQ rate: 0.67 USD per BSQ
  • Previous compensation request (if applicable): For Cycle 16 #648

Contributions delivered

Title Team USD Link Notes
DNS Admin admin* 25 bisq-network/roles#18 (comment)
Roles Maintainer admin* 25 bisq-network/roles#28 (comment)

Other notes

See my comment about continuing to play the GitHub Admin role as a secondary at #668.

@cbeams cbeams changed the title [WIP] For Cycle 17 For Cycle 17 Sep 22, 2020
@ghost ghost added parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:admin https://bisq.wiki/Admin_Team labels Sep 22, 2020
@cbeams
Copy link
Member Author

cbeams commented Sep 22, 2020

Please approve, @m52go.

@MwithM MwithM added this to In Review in Compensation Request Board Sep 22, 2020
@MwithM MwithM added this to the Cycle 17 milestone Sep 22, 2020
@m52go
Copy link

m52go commented Sep 22, 2020

Approved—please submit to the DAO and post txid here.

@m52go m52go moved this from In Review to Review Complete in Compensation Request Board Sep 22, 2020
@cbeams
Copy link
Member Author

cbeams commented Sep 24, 2020

Please submit to the DAO and post TXID here.

cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe

@MwithM MwithM moved this from Review Complete to Proposal Submitted in Compensation Request Board Sep 24, 2020
@MwithM MwithM added the was:rejected Indicates that a compensation request was rejected by DAO voting label Oct 5, 2020
@MwithM
Copy link
Contributor

MwithM commented Oct 5, 2020

Closed as rejected

@MwithM MwithM closed this as completed Oct 5, 2020
Compensation Request Board automation moved this from Proposal Submitted to Closed Oct 5, 2020
@MwithM MwithM moved this from Closed to In Progress in Compensation Request Board Oct 5, 2020
@MwithM MwithM moved this from In Progress to Closed in Compensation Request Board Oct 5, 2020
@cbeams
Copy link
Member Author

cbeams commented Oct 5, 2020

Attn: @chimp1984, @sqrrm

@MwithM wrote:

Closed as rejected

This seems very unusual. I've never had a request rejected before; this appears to be the only request rejected during this cycle; and it got unanimous downvotes! (I was unable to add my own upvote because I missed the voting deadline)

image

image

Any ideas how this might have happened? Was it something I said? ;)

I've also noticed that my BSQ issuance for Cycle 16 (which was approved, see #648) has not come through to my BSQ wallet. May be a completely separate issue, but seems worth mentioning here.

@sqrrm
Copy link
Member

sqrrm commented Oct 5, 2020

@cbeams I suspect your proposal didn't propagate before the vote. I didn't see it for example. I'm a bit fuzzy on exactly how the votes are counted, but I think that since your proposal wasn't part of the majority view of proposals it will count all votes that were part of the majority view as rejecting all non majority view proposals.

It looks like I didn't have it on Oct 1 and received it on Oct 4. That's strange since it looks like it was created 2020-09-25 06:25. Perhaps your log will show if you managed to broadcast it properly when it was created. My log for when I received it:

Oct-04 14:54:56.609 [JavaFX Application Thread] INFO  b.n.p.p.g.RequestDataHandler: 
#################################################################
Connected to node: fl3mmribyxgrv63c.onion:8000
Received 1748 instances
BlindVotePayload: 1
RefundAgent: 1
Filter: 1
TempProposalPayload: 2
TradeStatistics2: 300
MailboxStoragePayload: 745
ProposalPayload: 1
Mediator: 2
Alert: 1
AccountAgeWitness: 170
OfferPayload: 478
SignedWitness: 46
################################################################# 

@cbeams
Copy link
Member Author

cbeams commented Oct 5, 2020

Thanks, @sqrrm. Relevant bits from my log:

Sep-24 09:48:14.689 [JavaFX Application Thread] INFO b.c.d.g.p.MyProposalListService: Proposal tx has been published. TxId=cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe

Oct-04 08:56:18.426 [JavaFX Application Thread] INFO b.c.d.g.b.BallotListService: We create a new ballot with a proposal and add it to our list. Vote is null at that moment. proposalTxId=cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe

Oct-05 08:42:30.757 [JavaFX Application Thread] WARN  b.c.d.g.v.VoteResultService: We have a proposal which was not part of our blind vote and
reject it. Proposal=CompensationProposal{
     requestedBsq=7463,
     bsqAddress='B13i3GQgdiZpHDdrjiL7Z16xxnupuj4gc5k'
} Proposal{
     txId='cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe',
     name='cbeams',
     link='https://bisq.network/dao-compensation/668',
     txId='cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe',
     version=1,
     creationDate=Thu Sep 24 09:46:51 CEST 2020
}

The last block repeats 9 times.

Still not sure what happened or went wrong, further ideas welcome. Seems like a one-off for now; I'll resubmit next cycle.

@sqrrm
Copy link
Member

sqrrm commented Oct 5, 2020

The tx obviously broadcast properly since it was confirmed on the 25th, but the p2p data probably didn't get distributed until the 4th which was too late. Anything more from the 24th about the p2p data?

@cbeams
Copy link
Member Author

cbeams commented Oct 5, 2020

Just these lines, perhaps:

Sep-24 09:48:14.612 [JavaFX Application Thread] INFO b.c.d.g.p.ProposalService: We received a TempProposalPayload and store it to our protectedStoreList. proposalTxId=cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe

Sep-24 09:48:14.618 [JavaFX Application Thread] INFO b.c.d.g.p.MyProposalListService: TempProposalPayload has been added to P2P network. ProposalTxId=cf1216d60bb0639a95a4604b038e15dd500cb576ceb38f508a89379bb3344cbe

@chimp1984
Copy link

@cbeams can you send me the full logs (all 10 files). Maybe its related to the late BSQ tx from last cycle? I assume as well that the proposal data did not got distributed in time or have been invalid for yet unknown reasons.

@chimp1984
Copy link

Seems we have one more irregular tx. The others have been late proposals. Likely thats the case here as well... investigating...
Screen Shot 2020-10-05 at 21 24 52

@chimp1984
Copy link

Added breakpoint there and got your tx. So seems that the proposal data did not arriv ein time. If you quite the app quickly after proposal creation that can happen. Have not investigated further so far... but seems likely thats the issue.
Screen Shot 2020-10-05 at 21 55 50

@cbeams
Copy link
Member Author

cbeams commented Oct 6, 2020

@cbeams can you send me the full logs (all 10 files).

Sure. They're available at keybase://private/chimp1984%2Ccbeams/compensation-668-logs.tgz

@cbeams
Copy link
Member Author

cbeams commented Oct 23, 2020

Heads up: I'm putting together my compensation request for Cycle 18 now, and I will include the amount requested in this compensation request there.

@cbeams cbeams mentioned this issue Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parsed:valid https://bisq.wiki/Compensation#Ensure_your_request_is_valid team:admin https://bisq.wiki/Admin_Team was:rejected Indicates that a compensation request was rejected by DAO voting
Projects
Development

No branches or pull requests

5 participants